linux-kernel - Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110801103304.e77887ff2e60f4f6d5c9f91f@canb.auug.org.au>
Date:	Mon, 1 Aug 2011 10:33:04 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	akpm <akpm@...ux-foundation.org>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, Liam Girdwood <lrg@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h

On Mon, 1 Aug 2011 01:15:24 +0100 Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:
>
> On Fri, Jul 29, 2011 at 09:13:09PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@...otime.net>
> > 
> > aat2870-regulator.c needs to include linux/module.h to fix multiple
> > build errors.
> 
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> 
> but if the breakage isn't in mainline yet to minimize the breaks
> bisection someone should figure out which tree introduced the change
> with module.h and either get the fix merged along with that.  If neither
> the module.h change nor the driver is in Linus' tree yet I rather
> suspect this should go via MFD as I seem to recall that the driver is
> going in via there.

It is indeed.  I have this patch set to apply to my tree today after the
mfd tree.  Hopefully Samuel will put it in his tree for tomorrow (and
before he asks Linus to pull.

> It's not entirely clear to me why this started showing up part way
> through the merge window :/

Various people thought that the module.h split up was worth the effort,
so it got dropped into linux-next on Friday.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped