linux-kernel - Re: linux-next: build warnings after merge of the moduleh tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110801103537.a273ddac48fc81a8f28c2f90@canb.auug.org.au>
Date:	Mon, 1 Aug 2011 10:35:37 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	<linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Neil Brown <neilb@...e.de>, <linux-raid@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the moduleh tree

On Sun, 31 Jul 2011 04:24:05 -0400 Paul Gortmaker <paul.gortmaker@...driver.com> wrote:
>
> [linux-next: build warnings after merge of the moduleh tree] On 29/07/2011 (Fri 15:25) Stephen Rothwell wrote:
> 
> > Hi Paul,
> > 
> > After merging the moduleh tree, today's linux-next build (x86_64
> > allmodconfig) produced these warnings:
> > 
> > drivers/md/persistent-data/dm-block-manager.c:103:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-btree.c:146:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> > 
> > I have added the following patch for today:
> > 
> > From: Stephen Rothwell <sfr@...b.auug.org.au>
> > Date: Fri, 29 Jul 2011 15:16:04 +1000
> > Subject: [PATCH] include export.h to use EXPORT_SYMBOL
> > 
> > Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > ---
> >  drivers/md/persistent-data/dm-block-manager.c  |    1 +
> >  drivers/md/persistent-data/dm-btree-remove.c   |    2 ++
> >  drivers/md/persistent-data/dm-btree.c          |    1 +
> >  drivers/md/persistent-data/dm-space-map-disk.c |    1 +
> >  4 files changed, 5 insertions(+), 0 deletions(-)
> 
> This one is a bit more interesting.  The above files (and actually their
> parent dir) doesn't exist yet in master/HEAD.  So I can't patch them
> yet.  And the MD maintainers can't patch in export.h usage, since they
> won't have such a header file.
> 
> If you didn't want to temporarily carry it, I can think of two things:
> I suppose, since the one single commit that creates export.h is totally
> standalone, and harmless/inert in itself, we could perhaps get it pulled
> independently if it made life easier for others to align to the right
> usage?  Or they can just patch in module.h usage and we can downgrade
> them to export.h usage shortly thereafter.

I will carry it for now (as a merge fixup on the moduleh tree.  If the
export.h split goes to Linus, then Neil can apply it to his tree, or
Linus can apply it as a merge fixup ehen he merges the latter of the two
trees (as long as someone remember to tell him).

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped