linux-kernel - Re: [PATCH][Resend] Remove unneeded version.h includes (and add where needed) for drivers/usb/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Aug 2011 00:19:24 +0300
From:	Felipe Balbi <balbi@...com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	LKML <linux-kernel@...r.kernel.org>, trivial@...nel.org,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH][Resend] Remove unneeded version.h includes (and add
 where needed) for drivers/usb/

Hi,

On Mon, Aug 01, 2011 at 11:33:29PM +0200, Jesper Juhl wrote:
> It was pointed out by 'make versioncheck' that linux/version.h was not
> always being included where needed and sometimes included needlessly
> in drivers/usb/.
> This patch fixes up the includes.
> 
> For the UVC gadget driver bits, this was ACK'ed by Laurent Pinchart.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
>  drivers/usb/gadget/uvc.h         |    1 +
>  drivers/usb/gadget/uvc_v4l2.c    |    1 -
>  drivers/usb/storage/realtek_cr.c |    1 -
>  3 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h
> index 5b79194..81971fb 100644
> --- a/drivers/usb/gadget/uvc.h
> +++ b/drivers/usb/gadget/uvc.h
> @@ -56,6 +56,7 @@ struct uvc_event
>  #include <linux/usb.h>	/* For usb_endpoint_* */
>  #include <linux/usb/gadget.h>
>  #include <linux/videodev2.h>
> +#include <linux/version.h>

does uvc.h really needs <linux/version.h> ?? Laurent ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)