linux-kernel - Re: [PATCH][Resend] Remove unneeded version.h includes (and add where needed) for drivers/usb/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201108030011.54322.laurent.pinchart@ideasonboard.com>
Date:	Wed, 3 Aug 2011 00:11:53 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	balbi@...com
Cc:	Jesper Juhl <jj@...osbits.net>,
	LKML <linux-kernel@...r.kernel.org>, trivial@...nel.org,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net
Subject: Re: [PATCH][Resend] Remove unneeded version.h includes (and add where needed) for drivers/usb/

Hi Felipe,

On Tuesday 02 August 2011 23:19:24 Felipe Balbi wrote:
> On Mon, Aug 01, 2011 at 11:33:29PM +0200, Jesper Juhl wrote:
> > It was pointed out by 'make versioncheck' that linux/version.h was not
> > always being included where needed and sometimes included needlessly
> > in drivers/usb/.
> > This patch fixes up the includes.
> > 
> > For the UVC gadget driver bits, this was ACK'ed by Laurent Pinchart.
> > 
> > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> > Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > ---
> > 
> >  drivers/usb/gadget/uvc.h         |    1 +
> >  drivers/usb/gadget/uvc_v4l2.c    |    1 -
> >  drivers/usb/storage/realtek_cr.c |    1 -
> >  3 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h
> > index 5b79194..81971fb 100644
> > --- a/drivers/usb/gadget/uvc.h
> > +++ b/drivers/usb/gadget/uvc.h
> > @@ -56,6 +56,7 @@ struct uvc_event
> > 
> >  #include <linux/usb.h>	/* For usb_endpoint_* */
> >  #include <linux/usb/gadget.h>
> >  #include <linux/videodev2.h>
> > 
> > +#include <linux/version.h>
> 
> does uvc.h really needs <linux/version.h> ?? Laurent ?

uvc.h has

#define DRIVER_VERSION_NUMBER                   KERNEL_VERSION(0, 1, 0)

This is used in drivers/usb/gadget/uvc_v4l2.c only.

As the uvc gadget driver lives in-tree, the best fix is probably to remove 
DRIVER_VERSION_NUMBER completely, and replace it with LINUX_VERSION_CODE where 
it is used.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/