linux-kernel - Re: [PATCH] usb: musb: ux500: set dma config for both src and dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E390CF9.60503@stericsson.com>
Date:	Wed, 3 Aug 2011 10:55:21 +0200
From:	Mian Yousaf Kaukab <mian.yousaf.kaukab@...ricsson.com>
To:	Per FORLIN <per.forlin@...ricsson.com>, Felipe Balbi <balbi@...com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linaro-dev@...ts.linaro.org" <linaro-dev@...ts.linaro.org>,
	"users@...oocommunity.org" <users@...oocommunity.org>,
	Per Forlin <per.forlin@...aro.org>
Subject: Re: [PATCH] usb: musb: ux500: set dma config for both src and dst

On 08/02/2011 05:33 PM, Per FORLIN wrote:
> From: Per Forlin<per.forlin@...aro.org>
>
> The dma driver requires both src and dst to be set.
> This fix is needed in order to run gadget mass storage.
> Patch is verified on snowball.
>
> Signed-off-by: Per Forlin<per.forlin@...aro.org>
> ---
>   drivers/usb/musb/ux500_dma.c |   16 +++++++---------
>   1 files changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c
> index cecace4..2313475 100644
> --- a/drivers/usb/musb/ux500_dma.c
> +++ b/drivers/usb/musb/ux500_dma.c
> @@ -133,15 +133,13 @@ static bool ux500_configure_channel(struct dma_channel *channel,
>   					DMA_SLAVE_BUSWIDTH_4_BYTES;
>
>   	slave_conf.direction = direction;
> -	if (direction == DMA_FROM_DEVICE) {
> -		slave_conf.src_addr = usb_fifo_addr;
> -		slave_conf.src_addr_width = addr_width;
> -		slave_conf.src_maxburst = 16;
> -	} else {
> -		slave_conf.dst_addr = usb_fifo_addr;
> -		slave_conf.dst_addr_width = addr_width;
> -		slave_conf.dst_maxburst = 16;
> -	}
> +	slave_conf.src_addr = usb_fifo_addr;
> +	slave_conf.src_addr_width = addr_width;
> +	slave_conf.src_maxburst = 16;
> +	slave_conf.dst_addr = usb_fifo_addr;
> +	slave_conf.dst_addr_width = addr_width;
> +	slave_conf.dst_maxburst = 16;
> +
>   	dma_chan->device->device_control(dma_chan, DMA_SLAVE_CONFIG,
>   					     (unsigned long)&slave_conf);
>
>    

Acked-by: Mian Yousaf Kaukab <mian.yousaf.kaukab@...ricsson.com>

Thanks,

-- 
Mian Yousaf Kaukab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/