linux-kernel - Re: [PATCH] net/usb: Use kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110803090223.GM4587@distanz.ch>
Date:	Wed, 3 Aug 2011 11:02:23 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net/usb: Use kzalloc

Please add a Signed-off-by line as mentioned in
Documentation/SubmittingPatches.

Also you should Cc: the proper maintainer and list (in this case
netdev). You can use scripts/get_maintainers.pl to get this information

Cheers
Tobias

On 2011-08-02 at 18:09:28 +0200, Thomas Meyer <thomas@...3r.de> wrote:
> --- a/drivers/net/usb/cdc_ncm.c 2011-07-26 00:46:08.126846923 +0200
> +++ b/drivers/net/usb/cdc_ncm.c 2011-08-01 20:20:43.396390040 +0200
> @@ -479,12 +479,10 @@ static int cdc_ncm_bind(struct usbnet *d
>  	int temp;
>  	u8 iface_no;
>  
> -	ctx = kmalloc(sizeof(*ctx), GFP_KERNEL);
> +	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>  	if (ctx == NULL)
>  		return -ENODEV;
>  
> -	memset(ctx, 0, sizeof(*ctx));
> -
>  	init_timer(&ctx->tx_timer);
>  	spin_lock_init(&ctx->mtx);
>  	ctx->netdev = dev->net;
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/