linux-kernel - Re: [PATCH] pti: add missing CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUNh8tYrVn60aHY2dZ1jZNbBrhe_+V5AVxBTZqnTvH__A@mail.gmail.com>
Date:	Wed, 3 Aug 2011 09:20:48 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Heiko Carstens <heiko.carstens@...ibm.com>,
	akpm <akpm@...ux-foundation.org>,
	torvalds <torvalds@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	J Freyensee <james_p_freyensee@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pti: add missing CONFIG_PCI dependency

On Tue, Aug 2, 2011 at 17:11, Randy Dunlap <rdunlap@...otime.net> wrote:
> On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
>
>> From: Heiko Carstens <heiko.carstens@...ibm.com>
>>
>> allmodconfig compile fails on s390 because of the new PTI driver:
>>
>> drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
>> drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
>>
>> Add a 'depends on PCI' statement so it doesn't get compiled.
>>
>> Cc: J Freyensee <james_p_freyensee@...ux.intel.com>
>
> James has already acked my identical patch.
> The problem seems to be that we don't have a drivers/misc/ maintainter to
> merge the patch.
>
> Anyway:
> Acked-by: Randy Dunlap <rdunlap@...otime.net>

It's also missing

#include <linux/slab.h>
#include <linux/uaccess.h>

Cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/4429212/

drivers/misc/pti.c:249: error: implicit declaration of function 'kmalloc'
drivers/misc/pti.c:657: error: implicit declaration of function 'copy_from_user'
drivers/misc/pti.c:848: error: implicit declaration of function 'kzalloc'

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/