linux-kernel - Re: [PATCH] mmc: tmio: eliminate unused variable 'mmc' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Aug 2011 09:26:25 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Axel Lin <axel.lin@...il.com>
cc:	linux-kernel@...r.kernel.org, Ian Molton <ian@...menth.co.uk>,
	Chris Ball <cjb@...top.org>, linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: tmio: eliminate unused variable 'mmc' warning

On Wed, 3 Aug 2011, Axel Lin wrote:

> Fix below compile warning:
>   CC      drivers/mmc/host/tmio_mmc.o
> drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_suspend':
> drivers/mmc/host/tmio_mmc.c:30: warning: unused variable 'mmc'
> drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_resume':
> drivers/mmc/host/tmio_mmc.c:45: warning: unused variable 'mmc'
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Good for 3.1, do we also push such "harmless" compiler warning fixes to 
stable?

Acked-by: Guennadi Liakhovetski <g.liakhovetski@....de>

Thanks
Guennadi

> ---
>  drivers/mmc/host/tmio_mmc.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
> index 8d185de..44a9668 100644
> --- a/drivers/mmc/host/tmio_mmc.c
> +++ b/drivers/mmc/host/tmio_mmc.c
> @@ -27,7 +27,6 @@
>  static int tmio_mmc_suspend(struct platform_device *dev, pm_message_t state)
>  {
>  	const struct mfd_cell *cell = mfd_get_cell(dev);
> -	struct mmc_host *mmc = platform_get_drvdata(dev);
>  	int ret;
>  
>  	ret = tmio_mmc_host_suspend(&dev->dev);
> @@ -42,7 +41,6 @@ static int tmio_mmc_suspend(struct platform_device *dev, pm_message_t state)
>  static int tmio_mmc_resume(struct platform_device *dev)
>  {
>  	const struct mfd_cell *cell = mfd_get_cell(dev);
> -	struct mmc_host *mmc = platform_get_drvdata(dev);
>  	int ret = 0;
>  
>  	/* Tell the MFD core we are ready to be enabled */
> -- 
> 1.7.4.1
> 
> 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/