linux-kernel - Re: loop device auto release patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Aug 2011 21:58:24 -0400
From:	Phillip Susi <psusi@....rr.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Ayan George <ayan@...n.net>, linux-kernel@...r.kernel.org
Subject: Re: loop device auto release patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/15/2011 03:19 PM, Andrew Morton wrote:
> The patch appears to do two unrelated things.  That's generally frowned
> upon, but doesn't bother me much if the patch is small.
> 
> Still, splitting it into two patches (in which the bugfix is staged
> first) would be advantageous for people who might wish to backport the
> fix into earlier kernels.

It looks like this got stalled and someone emailed me asking what
happened to it.  I'm not sure that splitting the patch in two makes
sense.  I don't see how it does two unrelated things.  The uevent
problem was caused by the argument being NULL.  This patch just removes
the argument since it is entirely unnecessary.  Given that the argument
is gone and can no longer be passed as NULL, the tests for NULL are
rendered moot, and so removing them seems quite related.  I suppose you
could do the first and not the second, but then you would be leaving
cruft behind.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk45/MAACgkQJ4UciIs+XuL7+gCfUA8TpE2SRRCo+/VzRJMCrwg6
OEsAmwWphcaIF/wdguyHch6gEizv1Tjb
=pGGG
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/