linux-kernel - RE: [RFC PATCH v2] watchdog: ep93xx: Use the WatchDog Timer Driver Core.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ADE657CA350FB648AAC2C43247A983F001F3882B8D51@AUSP01VMBX24.collaborationhost.net>
Date:	Thu, 4 Aug 2011 16:54:56 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Mika Westerberg <mika.westerberg@....fi>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"wim@...ana.be" <wim@...ana.be>,
	"mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>
Subject: RE: [RFC PATCH v2] watchdog: ep93xx: Use the WatchDog Timer Driver
 Core.

On Thursday, August 04, 2011 11:13 AM, Mika Westerberg wrote:
> On Wed, Aug 03, 2011 at 10:21:26AM -0700, H Hartley Sweeten wrote:
>> Convert the ep93xx watchdog driver to using the WatchDog Timer Driver Core.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
>> Cc: Wim Van Sebroeck <wim@...ana.be>
>> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
>
> Tested-by: Mika Westerberg <mika.westerberg@....fi>
>
> BTW, now that the driver uses watchdog core should we also select
> WATCHDOG_CORE in the Kconfig? If it is not enabled we get:
>
> drivers/built-in.o: In function `ep93xx_wdt_init':
> clkdev.c:(.init.text+0x2bd8): undefined reference to
> `watchdog_register_device'
> make: *** [.tmp_vmlinux1] Error 1
>
> Other than that, you can also add my
>
> Reviewed-by: Mika Westerberg <mika.westerberg@....fi>
>
> if you like.

Mika,

I just posted a v3 of this patch that includes the Kconfig change to
select WATCHDOG_CORE.  Can you please take a look and possibly test it?

After that I'll add your Tested-by and Reviewed-by tags.

Thanks,
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/