linux-kernel - Re: [PATCH 2/2] omap_twl: Prevent SR to enable for am3517/am3505 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87hb5w3kq0.fsf@ti.com>
Date:	Thu, 04 Aug 2011 14:55:35 -0700
From:	Kevin Hilman <khilman@...com>
To:	Abhilash K V <abhilash.kv@...com>
Cc:	<linux-omap@...r.kernel.org>, <tony@...mide.com>,
	<linux@....linux.org.uk>, <b-cousson@...com>, <paul@...an.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, Vaibhav Hiremath <hvaibhav@...com>
Subject: Re: [PATCH 2/2] omap_twl: Prevent SR to enable for am3517/am3505 devices

Abhilash K V <abhilash.kv@...com> writes:

> From: Vaibhav Hiremath <hvaibhav@...com>
>
> In case of AM3517 & AM3505, Smart Reflex is not applicable so
> we must not enable it. So add check for am3517/05 cpu revision
> in omap3_twl_init() and return -ENODEV if true, else continue.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@...com>
> Signed-off-by: Abhilash K V <abhilash.kv@...com>
> ---
>  arch/arm/mach-omap2/omap_twl.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
> index 07d6140..92fadcb 100644
> --- a/arch/arm/mach-omap2/omap_twl.c
> +++ b/arch/arm/mach-omap2/omap_twl.c
> @@ -269,6 +269,14 @@ int __init omap3_twl_init(void)
>  	if (!cpu_is_omap34xx())
>  		return -ENODEV;
>  
> +	/*
> +	 * In case of AM3517/AM3505 we should not be going down
> +	 * further, since SR is not applicable there.
> +	 */
> +	if (cpu_is_omap3505() || cpu_is_omap3517()) {
> +		return -ENODEV;
> +	}
> +

Rather than using cpu_is_*, you should add a new "feature" flag for
SmartReflex.  We already have this for things like SGX, IVA, NEON, etc.
See <plat/feature.h>

Kevin


>  	if (cpu_is_omap3630()) {
>  		omap3_mpu_volt_info.vp_vddmin = OMAP3630_VP1_VLIMITTO_VDDMIN;
>  		omap3_mpu_volt_info.vp_vddmax = OMAP3630_VP1_VLIMITTO_VDDMAX;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/