linux-kernel - Re: [RFC][PATCH] of: add a dummy implementation of of_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110805090514.GA17391@distanz.ch>
Date:	Fri, 5 Aug 2011 11:05:14 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Colin Cross <ccross@...roid.com>,
	John Bonesio <bones@...retlab.ca>,
	"Jean Delvare (PC drivers, core)" <khali@...ux-fr.org>,
	"Ben Dooks (embedded platforms)" <ben-linux@...ff.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	linux-i2c@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	"Sam Ravnborg sam"@ravnborg.org
Subject: Re: [RFC][PATCH] of: add a dummy implementation of
	of_get_property() in of.h

On 2011-08-05 at 10:56:14 +0200, Axel Lin <axel.lin@...il.com> wrote:
> Then we can avoid having #ifdef CONFIG_OF splattered around the place
> calling of_get_property(), it leads to errors.

You shouldn't redefine of_get_property in the driver. Rather add a
wrapper function to the driver which will extract the device tree
information in CONFIG_OF is enabled and which will just return -ENODEV
if CONFIG_OF is not set.

Cheers
Tobias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/