linux-kernel - Re: next-200110804 ARM build break (cpuidle_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110805105231.7f8abe91210c30580ff40d52@canb.auug.org.au>
Date:	Fri, 5 Aug 2011 10:52:31 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Linus <torvalds@...ux-foundation.org>
Cc:	Stephen Warren <swarren@...dia.com>,
	Len Brown <len.brown@...el.com>,
	"Mark Brown (broonie@...nsource.wolfsonmicro.com)" 
	<broonie@...nsource.wolfsonmicro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: next-200110804 ARM build break (cpuidle_call_idle)

Hi Linus,

On Fri, 5 Aug 2011 09:29:41 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> On Thu, 4 Aug 2011 13:35:59 -0700 Stephen Warren <swarren@...dia.com> wrote:
> >
> > With next-20110804, I'm seeing the following on ARM:
> > 
> > arch/arm/kernel/process.c: In function 'cpu_idle':
> > arch/arm/kernel/process.c:200: error: implicit declaration of function 'cpuidle_call_idle'
> > 
> > This was previously fixed with:
> > 
> > https://lkml.org/lkml/2011/4/4/109
> > 
> > Commit 5f8cf82 (cpuidle: stop using pm_idle) converted arches to use
> > cpuidle_idle_call() but contained typos on ARM and SH transposing the
> > function name into cpuidle_call_idle().
> > 
> > Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> > 
> > (which I think was included directly in linux-next according to that
> > email thread)
> 
> Yeah, briefly by the looks of things.
> 
> > However, commit 5f8cf82 isn't in linux-next any more, but instead,
> > a0bfa13 "cpuidle: stop depending on pm_idle" has replaced it, and has
> > the same issue.
> 
> It was included first on April 4 and removed after I apllied tha bove fix
> on April 15.  From April 18 on, it was not in the tree at all.  I don't
> know why it has come back :-(
> 
> > Applying Mark's previous fix solves the build problem.
> 
> Hi Len.  This patch was wrong the first time around ...

More fun!

The last three commits in the idle tree that you took from Len were in
linux-next until April 15 and then disappeared until yesterday.  The last
of these was broken back then and has been committed exactly the same now
and still breaks arm and sh.

I have reverted that commit from your tree for today ...
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped