linux-kernel - Re: [PATCH] hwmon: add caseopen detection to w83627ehf driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312563350.9971.123.camel@groeck-laptop>
Date:	Fri, 5 Aug 2011 09:55:50 -0700
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Dmitry Artamonow <mad_soft@...ox.ru>
CC:	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	Ian Dobson <i.dobson@...net-ian.com>,
	Jean Delvare <khali@...ux-fr.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hwmon: add caseopen detection to w83627ehf driver

On Fri, 2011-08-05 at 09:00 -0400, Dmitry Artamonow wrote:
> Export caseopen alarm status into userspace for
> Winbond w83627* chips and also implement alarm clear knob.
> 
> Signed-off-by: Dmitry Artamonow <mad_soft@...ox.ru>

[ ... ]

> +static ssize_t
> +store_caseopen_clear(struct device *dev, struct device_attribute *attr,
> +			const char *buf, size_t count)

Another note: Please drop the "_clear" from the function name. It is
redundant with "store_". Another possible name would be
"clear_caseopen".

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/