linux-kernel - Re: [PATCH] mfd: Convert pcf50633 to use new register map API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110808050712.GA31168@opensource.wolfsonmicro.com>
Date:	Mon, 8 Aug 2011 14:07:14 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: Convert pcf50633 to use new register map API

On Mon, Aug 08, 2011 at 05:29:27AM +0200, Lars-Peter Clausen wrote:

> >  EXPORT_SYMBOL_GPL(pcf50633_reg_clear_bits);

> I would prefer making the wrappers static inline functions.

I considered doing this for all the conversions but preferred to go for
a minimal diff for ease of review, it seems better to do such code
motion changes later on.  Similarly for the return value stuff which
I'll update shortly.

> --- a/drivers/base/regmap/regmap-i2c.c
> +++ b/drivers/base/regmap/regmap-i2c.c
> @@ -70,6 +70,8 @@ static int regmap_i2c_read(struct device *dev,
>  	struct i2c_msg xfer[2];
>  	int ret;
> 
> +	printk("regmap_read: %d %d\n", reg_size, val_size);
> +

Clearly not ideal...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/