linux-kernel - Re: [PATCH] mfd: Convert pcf50633 to use new register map API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110822090313.GD4607@sortiz-mobl>
Date:	Mon, 22 Aug 2011 11:03:13 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: Convert pcf50633 to use new register map API

Hi Lars,

On Mon, Aug 08, 2011 at 05:29:27AM +0200, Lars-Peter Clausen wrote:
> 
> >  #include <linux/mfd/pcf50633/core.h>
> >  
> [...]
> >  /* Read a block of up to 32 regs  */
> >  int pcf50633_read_block(struct pcf50633 *pcf, u8 reg,
> >  					int nr_regs, u8 *data)
> >  {
> > -	int ret;
> > -
> > -	mutex_lock(&pcf->lock);
> > -	ret = __pcf50633_read(pcf, reg, nr_regs, data);
> > -	mutex_unlock(&pcf->lock);
> > -
> > -	return ret;
> > +	return regmap_raw_read(pcf->regmap, reg, data, nr_regs);
> >  }
> >  EXPORT_SYMBOL_GPL(pcf50633_read_block);
> 
> There are callers which expect pcf50633_read_block to return the number of
> bytes read. We could change the wrapper to return nr_regs if regmap_raw_read
> returns 0. But I guess it is best to just update the callers. Incremental patch
> which does this at the end of the mail.
I'd like to apply Mark's patch and yours. Could you please remove the
unnecesary printk in your patch and I'll go ahead.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/