linux-kernel - [RFC PATCH v3] Add new elevator ops for request context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <20110811090310.GA6779@july>
Date:	Thu, 11 Aug 2011 18:03:10 +0900
From:	Kyungmin Park <kmpark@...radead.org>
To:	jaxboe@...ionio.com
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	jh80.chung@...sung.com, shli@...nel.org, linux-mmc@...r.kernel.org
Subject: [RFC PATCH v3] Add new elevator ops for request context

Hi Jens

Now eMMC device requires the upper layer information to improve the data
performance and reliability.

. Context ID
Using the context information, it can sort out the data internally and improve the performance.
The main problem is that it's needed to define "What's the context". 
Actually I expect cfq queue has own unique ID but it doesn't so decide to use the pid instead

. Data Tag
Using the Data Tag (1-bit information), It writes the data at SLC area when it's hot data. So it can make the chip more reliable.
First I expect the REQ_META but current ext4 doesn't pass the WRITE_META. only use the READ_META. so it will modify the ext4 filesystem to send the REQ_META flags to know it from device drivers

With these characteristics, it's helpful to teach the device. After some consideration. it's needed to use the elevator and request helpers

Sample usage is following in drivers/mmc/card/block.c

	int context;

	if (req)
		context = elv_get_request_context(md->queue.queue, req);

Thank you,
Kyungmin Park
---
Changelog v3
- Don't create the request_hint structure from Jens
- Make a helper function from Jens/Shaohua

Changelog v2
- Don't add the request member. instead add new elevator ops from Jens

---
 static void flush_end_io(struct request *flush_rq, int error)
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 1f96ad6..45187e3 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -3800,6 +3800,16 @@ queue_fail:
 	return 1;
 }
 
+static int cfq_get_request_context(struct request *rq)
+{
+	struct cfq_queue *cfqq = RQ_CFQQ(rq);
+
+	if (cfqq)
+		return cfqq->pid;
+
+	return 0;
+}
+
 static void cfq_kick_queue(struct work_struct *work)
 {
 	struct cfq_data *cfqd =
@@ -4211,6 +4221,7 @@ static struct elevator_type iosched_cfq = {
 		.elevator_latter_req_fn =	elv_rb_latter_request,
 		.elevator_set_req_fn =		cfq_set_request,
 		.elevator_put_req_fn =		cfq_put_request,
+		.elevator_get_req_context_fn =	cfq_get_request_context,
 		.elevator_may_queue_fn =	cfq_may_queue,
 		.elevator_init_fn =		cfq_init_queue,
 		.elevator_exit_fn =		cfq_exit_queue,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 0e67c45..e564500 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -551,6 +551,19 @@ static inline void blk_clear_queue_full(struct request_queue *q, int sync)
 		queue_flag_clear(QUEUE_FLAG_ASYNCFULL, q);
 }
 
+static inline int elv_get_request_context(struct request_queue *q,
+			struct request *rq)
+{
+	struct elevator_queue *e = q->elevator;
+
+	if (!(rq->cmd_flags & REQ_ELVPRIV))
+		return 0;
+
+	if (e->ops->elevator_get_req_context_fn)
+		return e->ops->elevator_get_req_context_fn(rq);
+
+	return 0;
+}
 
 /*
  * mergeable request must not have _NOMERGE or _BARRIER bit set, nor may
diff --git a/include/linux/elevator.h b/include/linux/elevator.h
index d800d51..0005a6f 100644
--- a/include/linux/elevator.h
+++ b/include/linux/elevator.h
@@ -26,6 +26,7 @@ typedef int (elevator_may_queue_fn) (struct request_queue *, int);
 
 typedef int (elevator_set_req_fn) (struct request_queue *, struct request *, gfp_t);
 typedef void (elevator_put_req_fn) (struct request *);
+typedef int (elevator_get_req_context_fn) (struct request *);
 typedef void (elevator_activate_req_fn) (struct request_queue *, struct request *);
 typedef void (elevator_deactivate_req_fn) (struct request_queue *, struct request *);
 
@@ -52,6 +53,7 @@ struct elevator_ops
 
 	elevator_set_req_fn *elevator_set_req_fn;
 	elevator_put_req_fn *elevator_put_req_fn;
+	elevator_get_req_context_fn *elevator_get_req_context_fn;
 
 	elevator_may_queue_fn *elevator_may_queue_fn;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/