linux-kernel - Re: [PATCH 1/2][cleanup] memcg: renaming of mem variable to memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110811090318.GE8023@tiehlicka.suse.cz>
Date:	Thu, 11 Aug 2011 11:03:18 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	Raghavendra K T <raghukt@...ux.vnet.ibm.com>
Cc:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>,
	Arend van Spriel <arend@...adcom.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"David S. Miller" <davem@...emloft.net>,
	"nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>,
	Balbir Singh <bsingharora@...il.com>,
	"John W. Linville" <linville@...driver.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Ying Han <yinghan@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
Subject: Re: [PATCH 1/2][cleanup] memcg: renaming of mem variable to memcg

On Thu 11-08-11 14:27:06, Raghavendra K T wrote:
> On 08/11/2011 01:34 PM, Michal Hocko wrote:
> >On Wed 10-08-11 22:59:29, Raghavendra K T wrote:
> >[...]
> >>This patch renames all mem variables to memcg in source file.
> >
> >__mem_cgroup_try_charge for example uses local mem which cannot be
> >renamed because it already has a memcg argument (mem_cgroup **) then we
> >have mem_cgroup_try_charge_swapin and mem_cgroup_prepare_migration which
> >use mem_cgroup **ptr (I guess we shouldn't have more of them).
> >I think that __mem_cgroup_try_charge should use ptr pattern as well.
> >Other than that I think the clean up is good.
> >
> >With __mem_cgroup_try_charge:
> >Acked-by: Michal Hocko<mhocko@...e.cz>
> >
> >Thanks
> Agreed, Let me know whether you prefer whole patch to be posted or
> only the corresponding hunk.

I would go with the full (single) patch. I would also recommend to add
results of your tests into the changelog (which configurantion have been
tested and how did you test binary compatibility).

Thanks
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/