linux-kernel - Re: Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110811135912.GA23481@sgi.com>
Date:	Thu, 11 Aug 2011 08:59:12 -0500
From:	Jack Steiner <steiner@....com>
To:	Robin Holt <holt@....com>
Cc:	Jes Sorensen <Jes.Sorensen@...hat.com>,
	mike travis <travis@....com>, Tony Luck <tony.luck@...el.com>,
	Thomas Meyer <thomas@...3r.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Julia Lawall <julia@...u.dk>
Subject: Re: Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn_hwperf.c?

On Thu, Aug 11, 2011 at 05:58:29AM -0500, Robin Holt wrote:
> On Thu, Aug 11, 2011 at 08:12:45AM +0200, Jes Sorensen wrote:
> > On 08/08/11 23:37, Tony Luck wrote:
> > > On Mon, Aug 8, 2011 at 11:05 AM, Thomas Meyer <thomas@...3r.de> wrote:
> > >> The function sn_hwperf_op_cpu() seems to miss a corresponding put_cpu().
> > >>
> > >> Or is this done in another function? I didn't find it.
> > > 
> > > It would be hard to do it elsewhere - this function may not have done
> > > a get_cpu() [in the cpu == SN_HWPERF_ARG_ANY_CPU case].
> > > 
> > > The logic is a bit tortuous here ... perhaps simpler to split the tests
> > > up.  Does the attached patch look right?
> > 
> > Hi Tony,
> > 
> > You probably want someone from SGI to look at it, so I'll forward to
> > Robin Holt.
> > 
> > I haven't been at SGI for about 2 years now :)
> 
> And I will bounce the question on to Jack.  I believe he will probably
> pass it on to somebody more familiar with sn_hwperf.  Tony's patch looks
> much clearer to me.  I would have answered that I thought this was the
> right patch until I saw the '... else { put_cpu(); ...' which made me
> think we need a closer look.

Agree - looks like a missing put_cpu(). Tony's patch looks good to me. Much clearer.

Acked-by: Jack Steiner <steiner@....com>


--- jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/