linux-kernel - Re: [PATCH 1/2] add SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110814161532.GA30846@redhat.com>
Date:	Sun, 14 Aug 2011 18:15:32 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Daniel Lezcano <daniel.lezcano@...e.fr>
Cc:	akpm@...ux-foundation.org, bonbons@...ux-vserver.org,
	containers@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, serge@...lyn.com
Subject: Re: [PATCH 1/2] add SA_CLDREBOOT flag

On 08/11, Daniel Lezcano wrote:
>
> Add the SA_CLDREBOOT flag to enable the CLD_REBOOT on SIGCHLD
> when a process of a child pid namespace calls the reboot syscall.

I doubt this is really useful in general. SIGCHLD doesn't queue,
if the parent of init already has the pending SIGCHLD it won't see
CLD_REBOOTED anyway. Anyway, you do not need a special helper to
fill siginfo.

And personally I strongly dislike SA_CLDREBOOT. For what? Imho, this
is unnecessary complication. If we want SIGCHLD-on-reboot, just send
it unconditionally.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/