linux-kernel - Re: [PATCH 2/3] regulator: tps65910: fix list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110815153903.GA13172@opensource.wolfsonmicro.com>
Date:	Tue, 16 Aug 2011 00:39:07 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Johan Hovold <jhovold@...il.com>
Cc:	Liam Girdwood <lrg@...com>, Liam Girdwood <lrg@...mlogic.co.uk>,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 2/3] regulator: tps65910: fix list_voltage for VDD1 and
 VDD2

On Mon, Aug 15, 2011 at 05:12:53PM +0200, Johan Hovold wrote:
> On Mon, Aug 15, 2011 at 11:49:13PM +0900, Mark Brown wrote:

> > You've got a bunch of missing break statements introduced by the same
> > commit in the same driver causing the same runtime issue...

> Well, the first bug prevents any device from being used at all (as probe
> always fails). The second bug makes list_voltage return the wrong value
> for two regulators.

> I simply prefer fixing them separately as it will be more clear from the
> changelog what behaviours are being fixed -- especially as they are
> marked for stable.

As a reviewer I did a double take as I wasn't immediately sure if this
was actually a different patch or not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/