linux-kernel - Re: [PATCH 1/3] regulator: tps65910: fix device initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1314549177.3666.3.camel@odin>
Date:	Sun, 28 Aug 2011 17:32:57 +0100
From:	Liam Girdwood <lrg@...nel.org>
To:	Johan Hovold <jhovold@...il.com>
Cc:	Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 1/3] regulator: tps65910: fix device initialisation

Hi Johan,

On Mon, 2011-08-15 at 12:45 +0200, Johan Hovold wrote:
> Fix regression introduced by commit
> a320e3c3d6351814afa5182159df88d2637e0f6f (regulator: tps65911: Add new
> chip version) which broke probe for all devices:
> 
> 	"Invalid tps chip version"
> 
> Cc: stable@...nel.org
> Signed-off-by: Johan Hovold <jhovold@...il.com>
> ---
>  drivers/regulator/tps65910-regulator.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
> index 55dd4e6..bc5ed25 100644
> --- a/drivers/regulator/tps65910-regulator.c
> +++ b/drivers/regulator/tps65910-regulator.c
> @@ -898,9 +898,11 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
>  	case TPS65910:
>  		pmic->get_ctrl_reg = &tps65910_get_ctrl_register;
>  		info = tps65910_regs;
> +		break;
>  	case TPS65911:
>  		pmic->get_ctrl_reg = &tps65911_get_ctrl_register;
>  		info = tps65911_regs;
> +		break;
>  	default:
>  		pr_err("Invalid tps chip version\n");
>  		return -ENODEV;

Couldn't apply these as it seems there may already be fixes to some of
the issues fixed by your patches. Could you update and resend.

Thanks !

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/