linux-kernel - Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E4968F0.9050108@panasas.com>
Date:	Mon, 15 Aug 2011 11:44:00 -0700
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Maxin B John <maxin.john@...il.com>
CC:	<rdunlap@...otime.net>, Benny Halevy <bhalevy@...asas.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	<osd-dev@...n-osd.org>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator
 library

On 08/14/2011 04:18 PM, Maxin B John wrote:
> Ping..
> 
> On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@...il.com> wrote:
>> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
>> in Kconfig so that the requirements are met automatically.
>>
>> Signed-off-by: Maxin B. John <maxin.john@...il.com>

Yes sorry. It was on my todo and I never got to it.

OK So actually current osd_initiator code does not use these libraries.
It should, and I have very old code that started on that (hence the comment),
but it was never submitted to Kernel. The OSD protocol calls for all kind of
security levels that use these, but the current code only supports NO_SEC.

I will keep your patch for when security code goes in. Meanwhile I should
at least remove the stale comment.

Thanks
Boaz

>> ---
>> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
>> index 861b5ce..1535fe1 100644
>> --- a/drivers/scsi/osd/Kconfig
>> +++ b/drivers/scsi/osd/Kconfig
>> @@ -11,17 +11,16 @@
>>  # it under the terms of the GNU General Public version 2 License as
>>  # published by the Free Software Foundation
>>  #
>> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
>> -#        How is it done properly?
>>  #
>>
>>  config SCSI_OSD_INITIATOR
>>        tristate "OSD-Initiator library"
>>        depends on SCSI
>> +       select CRYPTO
>> +       select CRYPTO_SHA1
>> +       select CRYPTO_HMAC
>>        help
>>                Enable the OSD-Initiator library (libosd.ko).
>> -               NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
>> -               dependencies
>>
>>  config SCSI_OSD_ULD
>>        tristate "OSD Upper Level driver"
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/