linux-kernel - Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110815154607.8c34ffd02558b4d86e17e396@canb.auug.org.au>
Date:	Mon, 15 Aug 2011 15:46:07 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Shawn Guo <shawn.guo@...aro.org>
Cc:	Chris Ball <cjb@...top.org>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...aro.org
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of
 linux/module.h

Hi,

On Mon, 15 Aug 2011 13:35:58 +0800 Shawn Guo <shawn.guo@...aro.org> wrote:
>
> On 15 August 2011 11:54, Chris Ball <cjb@...top.org> wrote:
> >
> > On Sun, Aug 14 2011, Shawn Guo wrote:
> >> There are following warning and error when compiling the driver.
> >> The patch adds the missing inclusion of linux/module.h to fix them.
> >>
> >> drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has
> >> no type or storage class
> >
> > Pushed to mmc-next for 3.1.  I don't see these on my imx build with
> > CONFIG_MMC_SDHCI_ESDHC_IMX=m, so it'd be useful to see your .config
> > so that I'm able to reproduce in future.
> >
> I guess it's not about .config but sources.  I spot this on
> linux-next-20110812.  Are you trying the same tree?  I will test
> v3.1-rc2 tag when I can actually fetch it.  (Linus released it, but it
> has not been available with 'git fetch' yet.)

It could well be an interaction with the module.h split up, in which case
it will only appear in linux-next.   That said, I don;t get that error in
my manual builds, so the config (or at least ARCH) could be useful.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped