linux-kernel - Re: [PATCH] tty: clearify structure initializer in notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+rthh_AW5Yz2ZiOqOTWquXKnsDEd=YcNQ9HiOWu-deSar0eWQ@mail.gmail.com>
Date:	Tue, 16 Aug 2011 13:03:20 +0200
From:	Mathias Krause <minipli@...glemail.com>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Mathias Krause <minipli@...glemail.com>
Subject: Re: [PATCH] tty: clearify structure initializer in notify_write()

Ping, Greg?

On Sat, Jul 30, 2011 at 2:01 PM, Mathias Krause <minipli@...glemail.com> wrote:
> Even though this is valid C we should not mix C99 initializers with
> obfuscated ANSI C. Stick to C99 and initialize c by its name.
>
> Found by clang:
> drivers/tty/vt/vt.c:262:55: warning: explicitly assigning a variable of
> type 'unsigned int' to itself [-Wself-assign]
>    struct vt_notifier_param param = { .vc = vc, unicode = unicode };
>                                                 ~~~~~~~ ^ ~~~~~~~
>
> Signed-off-by: Mathias Krause <minipli@...glemail.com>
> ---
>  drivers/tty/vt/vt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index b3915b7..e716839 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(unregister_vt_notifier);
>
>  static void notify_write(struct vc_data *vc, unsigned int unicode)
>  {
> -       struct vt_notifier_param param = { .vc = vc, unicode = unicode };
> +       struct vt_notifier_param param = { .vc = vc, .c = unicode };
>        atomic_notifier_call_chain(&vt_notifier_list, VT_WRITE, &param);
>  }
>
> --
> 1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/