linux-kernel - Re: [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110816110330.GB27653@trinity.fluff.org>
Date:	Tue, 16 Aug 2011 12:03:30 +0100
From:	Ben Dooks <ben@...nity.fluff.org>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>
Subject: Re: [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks
	call for init_clocks

On Tue, Aug 16, 2011 at 08:48:22AM +0200, Heiko Stübner wrote:
> Am Dienstag, 16. August 2011, 05:04:41 schrieb Axel Lin:
> > Since commit af337f3e633a198034a99450416257ddf2307497
> > "ARM: S3C2443: Move parts of the clock code to common clock file",
> > the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c.
> > Now we call s3c_register_clocks for init_clocks in
> > s3c2443_common_init_clocks.
> > 
> > Thus we can remove the empty init_clocks array here and remove the
> > redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.
> I'm not 100% sure, but you might want to include Kukjin Kim 
> <kgene.kim@...sung.com> who seems to be handling the Samsung-stuff most of the 
> time.
> 
> Heiko

I'll pick this up, as there's plans to turn all the mach-s3c24xxs into
one big directory.
 
> > 
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> > ---
> >  arch/arm/mach-s3c2443/clock.c |    7 -------
> >  1 files changed, 0 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
> > index a1a7176..4018dbe 100644
> > --- a/arch/arm/mach-s3c2443/clock.c
> > +++ b/arch/arm/mach-s3c2443/clock.c
> > @@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
> >  	}
> >  };
> > 
> > -static struct clk init_clocks[] = {
> > -};
> > -
> >  /* clocks to add straight away */
> > 
> >  static struct clksrc_clk *clksrcs[] __initdata = {
> > @@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
> >  	for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
> >  		s3c_register_clksrc(clksrcs[ptr], 1);
> > 
> > -	/* register clocks from clock array */
> > -
> > -	s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
> > -
> >  	/* We must be careful disabling the clocks we are not intending to
> >  	 * be using at boot time, as subsystems such as the LCD which do
> >  	 * their own DMA requests to the bus can cause the system to lockup
> 

-- 
Ben Dooks, ben@...ff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/