linux-kernel - Re: [RFC patch resend] DMA engine/Langwell: process pending descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1313492905.1603.43.camel@vkoul-udesk3>
Date:	Tue, 16 Aug 2011 16:38:25 +0530
From:	Vinod Koul <vkoul@...radead.org>
To:	Hillf Danton <dhillf@...il.com>
Cc:	vinod.koul@...el.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC patch resend] DMA engine/Langwell: process pending
 descriptors

On Sat, 2011-08-13 at 11:57 +0800, Hillf Danton wrote:
> Descriptors could be added onto the queue list, though pending descriptors are
> checked in intel_mid_dma_issue_pending(), they are not processed by scanning
> the queue list. Now it is added.
> 
> Signed-off-by: Hillf Danton <dhillf@...il.com>
> ---
> 
> --- a/drivers/dma/intel_mid_dma.c	Sat Aug 13 11:44:46 2011
> +++ intel_mid_dma.c	Sat Aug 13 11:52:35 2011
This is wrong....

You should use git format-patch to generate the patches in your git
tree. Also send using git send-email will prevent errors in your patch.
While sending bunch of patches use git format-patch --cover-letter to
generate the diff stat and nice cover letter, that helps maintainer to
manage the patch series well

> @@ -338,8 +338,12 @@ static void midc_scan_descriptors(struct
>  		if (desc->status == DMA_IN_PROGRESS)
>  			midc_descriptor_complete(midc, desc);
>  	}
> -	return;
> +	list_for_each_entry_safe(desc, _desc, &midc->queue, desc_node) {
> +		if (desc->status == DMA_IN_PROGRESS)
> +			midc_descriptor_complete(midc, desc);
>  	}
> +}
> +
>  /**
>   * midc_lli_fill_sg -		Helper function to convert
>   *				SG list to Linked List Items.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/