linux-kernel - Re: [PATCH 3/4] drivers/media/video/hexium_gemini.c: delete useless initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110816135552.655ef654@endymion.delvare>
Date:	Tue, 16 Aug 2011 13:55:52 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Julia Lawall <julia@...u.dk>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	kernel-janitors@...r.kernel.org,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] drivers/media/video/hexium_gemini.c: delete useless
 initialization

Hi Julia,

On Thu,  4 Aug 2011 12:29:33 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> Delete nontrivial initialization that is immediately overwritten by the
> result of an allocation function.
> (...)
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  drivers/media/video/hexium_gemini.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -u -p a/drivers/media/video/hexium_gemini.c b/drivers/media/video/hexium_gemini.c
> --- a/drivers/media/video/hexium_gemini.c
> +++ b/drivers/media/video/hexium_gemini.c
> @@ -352,7 +352,7 @@ static struct saa7146_ext_vv vv_data;
>  /* this function only gets called when the probing was successful */
>  static int hexium_attach(struct saa7146_dev *dev, struct saa7146_pci_extension_data *info)
>  {
> -	struct hexium *hexium = (struct hexium *) dev->ext_priv;
> +	struct hexium *hexium;
>  	int ret;
>  
>  	DEB_EE((".\n"));
> 

Looks correct.

Acked-by: Jean Delvare <khali@...ux-fr.org>

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/