linux-kernel - Re: [patch] w1: off by one in w1_f29_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <56274C82-8FCA-45F9-B3DC-9863889694AA@gmail.com>
Date:	Wed, 17 Aug 2011 14:42:56 -0400
From:	Jean-Francois Dagenais <jeff.dagenais@...il.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	walter harms <wharms@....de>,
	Evgeniy Polyakov <johnpol@....mipt.ru>,
	Andrew Morton <akpm@...ux-foundation.org>,
	open list <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] w1: off by one in w1_f29_remove_slave()


On Jul 30, 2011, at 4:51, Dan Carpenter wrote:

> On Sat, Jul 30, 2011 at 10:42:29AM +0200, walter harms wrote:
>> Is there any reason to release the data "backwards" ?
>> The default way is to go upwards. that looks more readable.
> 
> I considered doing it that way.  It would work.  I throught maybe
> they were going to add something where it needed to be unwound LIFO
> order.
> 
> I'll wait for Jean-Françoisto say which way is prefered.
> 
Sorry for the delay. Sorry also for the trouble this dummy copy/paste mistake is causing. It's a bit embarrassing even if the intentions are good ;) This second mistake explains why I wasn't getting ill effects from the remove.

The sysfs files were removed backwards as a programmer reflex. In this case it is not really necessary since there are no real dependencies between the function implementations... but there may be in the future. This is why it's a safe habit to do it this way.

I would keep the removal in reverse order,  so I will ack the the v2 patch

Cheers!
/jfd
> regards,
> dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/