linux-kernel - Re: [patch 1/1] [PATCH] include storage keys in hibernation image.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110817094347.3c106bd9@mschwide>
Date:	Wed, 17 Aug 2011 09:43:47 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, Pavel Machek <pavel@....cz>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [patch 1/1] [PATCH] include storage keys in hibernation image.

On Tue, 16 Aug 2011 19:56:47 +0200
"Rafael J. Wysocki" <rjw@...k.pl> wrote:

> On Tuesday, August 16, 2011, Martin Schwidefsky wrote:
> > From: Martin Schwidefsky <schwidefsky@...ibm.com>
> > 
> > For s390 there is one additional byte associated with each page,
> > the storage key. This byte contains the referenced and changed
> > bits and needs to be included into the hibernation image.
> > If the storage keys are not restored to their previous state all
> > original pages would appear to be dirty. This can cause
> > inconsistencies e.g. with read-only filesystems.
> > 
> > Cc: Pavel Machek <pavel@....cz>
> > Cc: Rafael J. Wysocki <rjw@...k.pl>
> > Cc: Jiri Slaby <jslaby@...e.cz>
> > Cc: linux-pm@...ts.linux-foundation.org
> > Cc: linux-kernel@...r.kernel.org
> > Cc: linux-s390@...r.kernel.org
> > Signed-off-by: Martin Schwidefsky <schwidefsky@...ibm.com>
> 
> OK, I don't have any complaints.  Do you want me to take this
> patch or do you want to push it through the s390 tree?

The patch affects the common power management code. At minimum I
would like an acked-by to take it into the s390 tree. I would feel
more comfortable if you'd take it via the power management tree
though.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/