linux-kernel - Re: can't build modules after clean for powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110817074931.GA2629@merkur.ravnborg.org>
Date:	Wed, 17 Aug 2011 09:49:31 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Darren Hart <dvhart@...ux.intel.com>
Cc:	"lkml, " <linux-kernel@...r.kernel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Gary Thomas <gary@...assoc.com>,
	"Woodhouse, David" <david.woodhouse@...el.com>
Subject: Re: can't build modules after clean for powerpc

On Tue, Aug 16, 2011 at 05:36:56PM -0700, Darren Hart wrote:
> According to the Makefile comments and
> Documentation/kconfig/makefile.txt, make clean should leave enough
> intact to build modules with:
> 
> ###
> # Cleaning is done on three levels.
> # make clean     Delete most generated files
> #                Leave enough to build external modules
> 
> The following line in the arch/powerpc/Makefile prevents that from working:
> 
> KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
> 
> External module compilation fails to link as it can't find
> arch/powerpc/lib/crtsavres.o.
> 
> It appears from the make logs that crtsavres.o is linked in to
> built-in.o, and thus vmlinux. If that is the case, it doesn't seem like
> crtsavres.o should need to be singled out. What am I missing here?
> 
> If I comment it out:
> 
> #KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
> 
> my example module builds successfully.
> 
> If it is necessary, then we need a means to instruct the top level
> makefile to not delete it during "clean". Is there such a directive?
> 
> KBUILD_CLEAN_EXCLUDE_MODULES or something?

Hi Darren.
Try this small patch. Untested and cut'n'pasted...

	Sam


diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile
index 166a6a0..7a577f8 100644
--- a/arch/powerpc/lib/Makefile
+++ b/arch/powerpc/lib/Makefile
@@ -30,3 +30,6 @@ obj-$(CONFIG_PPC_LIB_RHEAP) += rheap.o
 obj-y                  += code-patching.o
 obj-y                  += feature-fixups.o
 obj-$(CONFIG_FTR_FIXUP_SELFTEST) += feature-fixups-test.o
+
+# crtsavres is used by modules - so we need it after "make clean"
+no-clean-files := crtsavres.o


> 
> Thanks,
> 
> -- 
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/