linux-kernel - Re: [REGRESSION][BISECTED] Notebook crashes upon detecting the PCI subsystem with kernels >= 2.6.24-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOtrxKNVckzkxM=ahV13kV=7-Jtj=WWkx_So4pCdVX3e8mdjPw@mail.gmail.com>
Date:	Fri, 19 Aug 2011 15:49:44 -0300
From:	Rogério Brito <rbrito@....usp.br>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Thomas Meyer <thomas@...3r.de>,
	Gary Hade <garyhade@...ibm.com>, Ingo Molnar <mingo@...e.hu>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION][BISECTED] Notebook crashes upon detecting the PCI
 subsystem with kernels >= 2.6.24-rc7

Hi once again.

2011/8/19 Rogério Brito <rbrito@....usp.br>:
> ,----[ git bisect bad ]
> | 12c22d6ef299ccf0955e5756eb57d90d7577ac68 is the first bad commit
> | commit 12c22d6ef299ccf0955e5756eb57d90d7577ac68
> | Author: Linus Torvalds <torvalds@...ux-foundation.org>
> | Date:   Wed Mar 26 11:22:40 2008 -0700
> |
> |     Revert "PCI: remove transparent bridge sizing"
(...)
> `----

Reverting the commit above with the patch below makes me able to
compile and run Linus's v3.1-rc2:

diff --cc drivers/pci/setup-bus.c
index 8a1d3c7,125e7b7..0000000
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@@ -783,16 -486,14 +783,14 @@@ void __ref __pci_bus_size_bridges(struc
  		break;

  	case PCI_CLASS_BRIDGE_PCI:
+ 		/* don't size subtractive decoding (transparent)
+ 		 * PCI-to-PCI bridges */
+ 		if (bus->self->transparent)
+ 			break;
  		pci_bridge_check_ranges(bus);
- 		if (bus->self->is_hotplug_bridge) {
- 			additional_io_size  = pci_hotplug_io_size;
- 			additional_mem_size = pci_hotplug_mem_size;
- 		}
- 		/*
- 		 * Follow thru
- 		 */
+ 		/* fall through */
  	default:
 -		pbus_size_io(bus);
 +		pbus_size_io(bus, 0, additional_io_size, add_head);
  		/* If the bridge supports prefetchable range, size it
  		   separately. If it doesn't, or its prefetchable window
  		   has already been allocated by arch code, try



-- 
Rogério Brito : rbrito@...e.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/