linux-kernel - Re: [Bug 41622] [REGRESSION][BISECTED] Notebook crashes upon detecting the PCI subsystem with kernels >= 2.6.24-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyyJNnL54o=xRH7CubFLDaQwcF31sqd7tfBcfR8XfnX5g@mail.gmail.com>
Date:	Wed, 24 Aug 2011 10:47:43 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Rogério Brito <rbrito@....usp.br>
Cc:	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Thomas Meyer <thomas@...3r.de>,
	Gary Hade <garyhade@...ibm.com>, Ingo Molnar <mingo@...e.hu>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	bugme-daemon@...zilla.kernel.org
Subject: Re: [Bug 41622] [REGRESSION][BISECTED] Notebook crashes upon
 detecting the PCI subsystem with kernels >= 2.6.24-rc7

2011/8/19 Rogério Brito <rbrito@....usp.br>:
>
> Reverting the commit above with the patch below makes me able to
> compile and run Linus's v3.1-rc2:

Oh, I just noticed that the "revert" you did actually does way more than revert.

> diff --cc drivers/pci/setup-bus.c
> index 8a1d3c7,125e7b7..0000000
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@@ -783,16 -486,14 +783,14 @@@ void __ref __pci_bus_size_bridges(struc
>                break;
>
>        case PCI_CLASS_BRIDGE_PCI:
> +               /* don't size subtractive decoding (transparent)
> +                * PCI-to-PCI bridges */
> +               if (bus->self->transparent)
> +                       break;

The above is the real revert.

The below should be totally independent, and I'd like to make sure
that you test the revert without this change:

>                pci_bridge_check_ranges(bus);
> -               if (bus->self->is_hotplug_bridge) {
> -                       additional_io_size  = pci_hotplug_io_size;
> -                       additional_mem_size = pci_hotplug_mem_size;
> -               }
> -               /*
> -                * Follow thru
> -                */
> +               /* fall through */
>        default:
>  -              pbus_size_io(bus);
>  +              pbus_size_io(bus, 0, additional_io_size, add_head);

And in fact I think that last line is just broken, you can't apply
that on my current -git. What's going on?

Also, I'd like to see the output of:

 - cat /proc/iomem
 - cat /proc/ioports
 - /sbin/lspci -vvxxx

from that machine. And Bjorn asked for a full dmesg, and I see that
email, but it didn't get updated into the bugzilla entry (apparently
bugzilla is not smart enough to take email attachments and make them
bugzilla attachments). Rogério, can you do that so that it doesn't get
lost?

                                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/