linux-kernel - Re: [PATCH] Sound, Cirrus: Remove redundant check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOZdJXUOLmT1eGZ7wEtk_UacYCPVz_caZwsnOPE_jFNq5svc-g@mail.gmail.com>
Date:	Sat, 20 Aug 2011 00:16:57 +0000
From:	Tabi Timur-B04825 <B04825@...escale.com>
To:	Jesper Juhl <jj@...osbits.net>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"Edgar (gimli) Hucek" <gimli@...k-green.com>,
	Tim Howe <tim.howe@...rus.com>,
	Stephen Warren <swarren@...dia.com>,
	Vince Weaver <vweaver1@...s.utk.edu>,
	Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH] Sound, Cirrus: Remove redundant check

On Fri, Aug 19, 2011 at 6:00 PM, Jesper Juhl <jj@...osbits.net> wrote:
> The variable 'idxp' is a pointer to 'unsigned int', so the value
> obtained when dereferencing it is always greater than or equal to
> 0. Testing this is redundant.

snd_hda_get_conn_index() can return a negative number, so maybe *idxp
should be a pointer to a signed int?

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/