linux-kernel - Re: [PATCH] kconfig: fix set but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACqU3MWoa5eNpgODqAKDSBZOL61OFWVqaKe_cH=bOMbxjRM0rA@mail.gmail.com>
Date:	Fri, 19 Aug 2011 20:28:33 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
Cc:	Michal Marek <mmarek@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kconfig: fix set but not used variables

Hi,

On Mon, Aug 15, 2011 at 10:41 AM, Lucas De Marchi
<lucas.demarchi@...fusion.mobi> wrote:
> Some variables were being set but never used, which was triggering
> warnings in recent versions of GCC.
>
Please be specific about the version of gcc triggering the warning. In
5 years, "recent version" will mean something than today.

Thanks,
 - Arnaud

> Signed-off-by: Lucas De Marchi <lucas.demarchi@...fusion.mobi>
> ---
>  scripts/kconfig/lxdialog/textbox.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
> index c704712..154c2dd 100644
> --- a/scripts/kconfig/lxdialog/textbox.c
> +++ b/scripts/kconfig/lxdialog/textbox.c
> @@ -320,7 +320,6 @@ static void print_page(WINDOW * win, int height, int width)
>  */
>  static void print_line(WINDOW * win, int row, int width)
>  {
> -       int y, x;
>        char *line;
>
>        line = get_line();
> @@ -329,10 +328,10 @@ static void print_line(WINDOW * win, int row, int width)
>        waddch(win, ' ');
>        waddnstr(win, line, MIN(strlen(line), width - 2));
>
> -       getyx(win, y, x);
>        /* Clear 'residue' of previous line */
>  #if OLD_NCURSES
>        {
> +               int x = getcurx(win);
>                int i;
>                for (i = 0; i < width - x; i++)
>                        waddch(win, ' ');
> --
> 1.7.6
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/