linux-kernel - Re: [PATCH 14/14] [media] gspca: Use current logging styles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110822105003.0002ef3c@tele>
Date:	Mon, 22 Aug 2011 10:50:03 +0200
From:	Jean-Francois Moine <moinejf@...e.fr>
To:	Joe Perches <joe@...ches.com>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/14] [media] gspca: Use current logging styles

On Sun, 21 Aug 2011 15:56:57 -0700
Joe Perches <joe@...ches.com> wrote:

> Add pr_fmt.
> Convert usb style logging macros to pr_<level>.
> Remove now unused old usb style logging macros.

Hi Joe,

Sorry, but I do not see the advantages of your patch.

For gspca, the source files are bigger, and the only visible change is
the display of the real module name instead of the name defined by hand
(this change may have been done just in gspca.h).

Also, I think that defining 'pr_fmt' in each source file is not a good
idea...

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/