linux-kernel - Re: [PATCH] DMA: PL330: add missing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1314097039.22120.160.camel@vkoul-udesk3>
Date:	Tue, 23 Aug 2011 16:27:19 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Dan <dan.j.williams@...el.com>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Boojin Kim <boojin.kim@...sung.com>,
	linux-kernel@...r.kernel.org, 'Kukjin Kim' <kgene.kim@...sung.com>
Subject: Re: [PATCH] DMA: PL330: add missing header

On Tue, 2011-08-23 at 10:39 +0100, Russell King - ARM Linux wrote:
> On Tue, Aug 23, 2011 at 02:02:47PM +0530, Koul, Vinod wrote:
> > On Tue, 2011-08-23 at 09:23 +0100, Russell King - ARM Linux wrote:
> > > On Tue, Aug 23, 2011 at 01:45:42PM +0530, Koul, Vinod wrote:
> > > > Russell had fixed compilation of pl330 driver, and was supposed to send
> > > > the fix to Linus as part of his fixes. If thats not done I can send it
> > > > for next -rc
> > > 
> > > That was for amba-pl08x.c, not pl330.c
> > Okay, thanks.
> > I will send the patch for dmaengine.h to Linus for next -rc
> 
> If you read the original commit, you'll find that scatterlist.h was
> explicitly removed from dmaengine.h:
> 
>     net: remove mm.h inclusion from netdevice.h
> 
>     Remove linux/mm.h inclusion from netdevice.h -- it's unused (I've checked ma
> 
>     To prevent mm.h inclusion via other channels also extract "enum dma_data_dir
>     definition into separate header. This tiny piece is what gluing netdevice.h
>     via "netdevice.h => dmaengine.h => dma-mapping.h => scatterlist.h => mm.h".
>     Removal of mm.h from scatterlist.h was tried and was found not feasible
>     on most archs, so the link was cutoff earlier.
> 
>     Hope people are OK with tiny include file.
> 
>     Note, that mm_types.h is still dragged in, but it is a separate story.
> 
>     Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
>     Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> So adding scatterlist.h back into dmaengine.h may not be the best idea.
Yes, looks like that maybe the case. 

It's rather unfortunate that neither Dan nor me were copied on changes
done on dmaengine drivers and headers :(


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/