linux-kernel - Re: [stable] [PATCH] uio/gen-pci: don't enable interrupts in ISR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110823110001.GB29209@local>
Date:	Tue, 23 Aug 2011 13:00:01 +0200
From:	"Hans J. Koch" <hjk@...sjkoch.de>
To:	"Hans J. Koch" <hjk@...sjkoch.de>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Greg KH <greg@...ah.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Chris Wright <chrisw@...hat.com>,
	Anthony Foiani <anthony.foiani@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>, stable@...nel.org
Subject: Re: [stable] [PATCH] uio/gen-pci: don't enable interrupts in ISR

On Tue, Aug 23, 2011 at 12:57:42PM +0200, Hans J. Koch wrote:
> On Tue, Aug 23, 2011 at 10:40:05AM +0200, Sebastian Andrzej Siewior wrote:
> > * Greg KH | 2011-08-22 17:49:43 [-0700]:
> > 
> > >> > Cc: Anthony Foiani <anthony.foiani@...il.com>
> > >
> > >Why, it's not fixing a bug that anyone hits, right?
> > 
> > "earlier" the interrupt handler was executed either with interrupts
> > enabled or disabled if IRQF_DISABLED was specified. Later the latter
> > become default even if IRQF_DISABLED was not specified. This lead to the
> > splat Anthony reported because the irq handler was entered with IRQs
> > disabled and the ISR enabled them via spin_unlock_irq(). My initial
> > patch simply used spin_unlock_irqrestore() (and its counterpart) to have
> > the same state as we had.
> > 
> > So the bug Anthony hit was that the interrupts were enabled where they
> > should not be.
> > 
> > >greg k-h
> > 
> > Sebastian
> > 
> 
> Greg, I'll change the commit message so that it becomes clear, and send
> you a pull request.
> 
> There is also one more UIO patch pending. Do you want a separate branch
> for -stable, or can you cherry-pick that from one UIO branch?

Forget it, I just saw you already added it to your tree.

Thanks,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/