linux-kernel - Re: [Doc] class_find_device: fix reference to argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110823004839.GA29215@kroah.com>
Date:	Mon, 22 Aug 2011 17:48:39 -0700
From:	Greg KH <greg@...ah.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Wanlong Gao <wanlong.gao@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [Doc] class_find_device: fix reference to argument

On Sun, Aug 21, 2011 at 02:53:55PM -0700, Randy Dunlap wrote:
> On Sun, 21 Aug 2011 14:46:04 +0000 (UTC) Wanlong Gao wrote:
> 
> > Rolf Eike Beer <eike <at> sf-mail.de> writes:
> > 
> > > 
> > > Signed-off-by: Rolf Eike Beer <eike-kernel <at> sf-tec.de>
> > > ---
> > >  drivers/base/class.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > 
> > > - * @fn is allowed to do anything including calling back into class
> > > + * @match is allowed to do anything including calling back into class
> > >   * code.  There's no locking restriction.
> > >   */
> > >  struct device *class_find_device(struct class *class, struct device *start,
> > 
> > NACK, it means the function class_find_device but not the @match.
> 
> Are you sure?  Looks to me like a comment that was copied from
> class_for_each_device() but shouldn't have been copied.
> 
> Anyway, I'll cc: Greg to see if he knows.

I think the above patch is probably correct, as it can reenter if
needed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/