linux-kernel - Re: [stable] [PATCH] uio/gen-pci: don't enable interrupts in ISR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110823004943.GB29215@kroah.com>
Date:	Mon, 22 Aug 2011 17:49:43 -0700
From:	Greg KH <greg@...ah.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	"Hans J. Koch" <hjk@...sjkoch.de>,
	Chris Wright <chrisw@...hat.com>,
	Anthony Foiani <anthony.foiani@...il.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>, stable@...nel.org
Subject: Re: [stable] [PATCH] uio/gen-pci: don't enable interrupts in ISR

On Wed, Aug 10, 2011 at 11:40:12AM +0300, Michael S. Tsirkin wrote:
> On Tue, Aug 09, 2011 at 08:53:41PM +0200, Hans J. Koch wrote:
> > On Tue, Aug 09, 2011 at 02:37:43PM +0300, Michael S. Tsirkin wrote:
> > > > 
> > > > Should I hack up a patch to remove the lock, or do you have anything in your
> > > > pipeline?
> > > 
> > > 
> > > Please do.
> > > 
> > 
> > Here it is:
> > 
> > Greg (and anyone else...), you can also pull this from branch "uio-for-greg" from
> > 
> > git://hansjkoch.de/git/linux-hjk
> > 
> > 
> > >From ff74627ade002d40fe1f902b7aadab8b1f15f889 Mon Sep 17 00:00:00 2001
> > From: "Hans J. Koch" <hjk@...sjkoch.de>
> > Date: Tue, 9 Aug 2011 20:34:31 +0200
> > Subject: [PATCH] uio: uio_pci_generic: Remove useless spin_lock
> > 
> > The spin_lock in uio_pci_generic.c is only used in the interrupt
> > handler, which cannot be executed twice at the same time.
> > That makes the lock rather pointless. This patch removes it.
> > 
> > Cc: "Michael S. Tsirkin" <mst@...hat.com>
> > Cc: Chris Wright <chrisw@...hat.com>
> > Cc: Jesse Barnes <jbarnes@...tuousgeek.org>
> > Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> > Cc: Anthony Foiani <anthony.foiani@...il.com>
> > Reported-by: Anthony Foiani <anthony.foiani@...il.com>
> > Reported-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> > Signed-off-by: Hans J. Koch <hjk@...sjkoch.de>
> 
> 
> Acked-by: Michael S. Tsirkin <mst@...hat.com>
> 
> I also suggest this for the stable trees.

Why, it's not fixing a bug that anyone hits, right?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/