linux-kernel - Re: [PATCHv4 1/4] usb: Provide usb_speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110824085738.GE12549@legolas.emea.dhcp.ti.com>
Date:	Wed, 24 Aug 2011 11:57:39 +0300
From:	Felipe Balbi <balbi@...com>
To:	Michal Nazarewicz <mina86@...a86.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Felipe Balbi <balbi@...com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Yang Rui Rui <ruirui.r.yang@...to.com>,
	Dave Young <hidave.darkstar@...il.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 1/4] usb: Provide usb_speed_string() function

Hi,

On Mon, Aug 22, 2011 at 11:16:07PM +0200, Michal Nazarewicz wrote:
> >>>>+obj-$(CONFIG_USB)		+= common.o
> >>>>+obj-$(CONFIG_USB_GADGET)	+= common.o
> 
> >>>Will this cause problems?  For example, what if CONFIG_USB is Y and
> >>>CONFIG_USB_GADGET is M?
> 
> >>>Also, it seems a little silly to have an entire kernel module devoted
> >>>to a single, little function.
> 
> On Mon, 22 Aug 2011 23:06:43 +0200, Alan Stern
> <stern@...land.harvard.edu> wrote:
> >You could do:
> >
> >	obj-$(CONFIG_USB_SUPPORT)  += common.o
> >
> >which would build that subroutine into the main kernel whenever either
> >side of the USB stack is enabled.
> 
> OK.  I'll wait for any more possible comments and post changed version
> by the end of the week.

if it's only for one single function, wouldn't a static inline in a
common header do ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)