linux-kernel - Re: [PATCHv4 3/4] usb: gadget: rename usb_gadget_driver::speed to max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110824085828.GF12549@legolas.emea.dhcp.ti.com>
Date:	Wed, 24 Aug 2011 11:58:29 +0300
From:	Felipe Balbi <balbi@...com>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	Michal Nazarewicz <mnazarewicz@...gle.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Felipe Balbi <balbi@...com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Yang Rui Rui <ruirui.r.yang@...to.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 3/4] usb: gadget: rename usb_gadget_driver::speed to
 max_speed

Hi,

On Wed, Aug 24, 2011 at 10:26:53AM +0800, Dave Young wrote:
> On Tue, Aug 23, 2011 at 12:04 AM, Michal Nazarewicz
> <mnazarewicz@...gle.com> wrote:
> > From: Michal Nazarewicz <mina86@...a86.com>
> >
> > This commit renames the “speed” field of the usb_gadget_driver
> > structure to “max_speed”.  This is so that to make it more
> > apparent that the field represents the maximum speed gadget
> > driver can support.
> >
> > This also make the field look more like fields with the same
> > name in usb_gadget and usb_composite_driver structures.  All
> > of those represent the *maximal* speed given entity supports.
> >
> > After this commit, there are the following fields in various
> > structures:
> > * usb_gadget::speed - the current connection speed,
> > * usb_gadget::max_speed - maximal speed UDC supports,
> > * usb_gadget_driver::max_speed - maximal speed gadget driver
> >  supports, and
> > * usb_composite_driver::max_speed - maximal speed composite
> >  gadget supports.
> >
> > Signed-off-by: Michal Nazarewicz <mina86@...a86.com>
> > ---
> >  drivers/usb/gadget/amd5536udc.c   |    2 +-
> >  drivers/usb/gadget/ci13xxx_udc.c  |    2 +-
> >  drivers/usb/gadget/composite.c    |    8 ++++----
> >  drivers/usb/gadget/dbgp.c         |    2 +-
> >  drivers/usb/gadget/dummy_hcd.c    |   13 ++++++-------
> >  drivers/usb/gadget/file_storage.c |    4 ++--
> >  drivers/usb/gadget/gmidi.c        |    2 +-
> >  drivers/usb/gadget/goku_udc.c     |    2 +-
> >  drivers/usb/gadget/inode.c        |    6 +++---
> >  drivers/usb/gadget/m66592-udc.c   |    2 +-
> >  drivers/usb/gadget/net2272.c      |    2 +-
> >  drivers/usb/gadget/net2280.c      |    2 +-
> >  drivers/usb/gadget/pch_udc.c      |    2 +-
> >  drivers/usb/gadget/printer.c      |    2 +-
> >  drivers/usb/gadget/r8a66597-udc.c |    2 +-
> >  include/linux/usb/gadget.h        |    4 ++--
> >  16 files changed, 28 insertions(+), 29 deletions(-)
> >
> 
> Still missing drivers/usb/musb/musb_gadget for the speed check

and the new DWC3 on Greg's usb-next branch.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)