linux-kernel - Re: linux-next: build failure after merge of the final tree (staging tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110825085420.521cc24fddadc7753dc67199@canb.auug.org.au>
Date:	Thu, 25 Aug 2011 08:54:20 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Greg KH <greg@...ah.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	edwin_rong <edwin_rong@...lsil.com.cn>
Subject: Re: linux-next: build failure after merge of the final tree
 (staging tree related)

Hi Greg,

On Wed, 24 Aug 2011 14:16:46 -0700 Greg KH <greg@...ah.com> wrote:
>
> To fix it, all we have to do is include linux/vmalloc.h, right?  Or is

I would assume so.

> ppc "special" in some other way regarding this call?

I assume it happens just because vmalloc.h is implicitly included by some
other header file on x86 and not on ppc.

This is why we have "Rule 1" in Documentation/SubmitChecklist.  Relying
on the implicit inclusion of header files is bound to trip us up on some
architecture or platform or combination of CONFIG options.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped