linux-kernel - Re: linux-next: build failure after merge of the final tree (staging tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110824225758.GA3454@kroah.com>
Date:	Wed, 24 Aug 2011 15:57:58 -0700
From:	Greg KH <greg@...ah.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	edwin_rong <edwin_rong@...lsil.com.cn>
Subject: Re: linux-next: build failure after merge of the final tree (staging
 tree related)

On Thu, Aug 25, 2011 at 08:54:20AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Wed, 24 Aug 2011 14:16:46 -0700 Greg KH <greg@...ah.com> wrote:
> >
> > To fix it, all we have to do is include linux/vmalloc.h, right?  Or is
> 
> I would assume so.
> 
> > ppc "special" in some other way regarding this call?
> 
> I assume it happens just because vmalloc.h is implicitly included by some
> other header file on x86 and not on ppc.
> 
> This is why we have "Rule 1" in Documentation/SubmitChecklist.  Relying
> on the implicit inclusion of header files is bound to trip us up on some
> architecture or platform or combination of CONFIG options.

Fair enough, I've made this fix in my tree, so it should be good now.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/