linux-kernel - Re: [Drbd-dev] [RFC 000/118] drbd: part 1 of adding multiple volume support to drbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGpXXZK4wSCoVfyGpwt7ygN_8mqQ1cNzuVD4XsWXunJzUvEX+g@mail.gmail.com>
Date:	Mon, 29 Aug 2011 09:26:16 -0400
From:	Greg Freemyer <greg.freemyer@...il.com>
To:	Philipp Reisner <philipp.reisner@...bit.com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
	drbd-dev@...ts.linbit.com
Subject: Re: [Drbd-dev] [RFC 000/118] drbd: part 1 of adding multiple volume
 support to drbd

On Mon, Aug 29, 2011 at 7:46 AM, Philipp Reisner
<philipp.reisner@...bit.com> wrote:
> Am Freitag, 26. August 2011, 15:20:51 schrieb Greg Freemyer:
>> On Thu, Aug 25, 2011 at 11:06 AM, Philipp Reisner <
>>
>> philipp.reisner@...bit.com> wrote:
>> > This the first request for review of drbd-8.4. The complete set has
>> > 500 patches. In this first series there are only 118 of these.
>>
>> Lars,
>>
>> I've only taken a quick glance, but is drbd functional between applying
>> each patch?
>>
>> It doesn't look like it to me, but I didn't look that close.  I also saw at
>> least one patch that introduced a new function with no caller to test it.
>>
>> The idea is that a patch series leave a testable / functional kernel after
>> each patch in the series is applied sequentially.
>>
>> That is the only way git bisect can do its job.
>>
>> ie. Introducing a new function but no new caller makes a change, but there
>> is no way to test it.  Therefore there is no real value in not merging that
>> patch with one that has the new call in it.
>>
>
> Greg,
>
> You replied to mail 000. Please point out to which patch/function you
> refer, so that we can fix this.
>
> Best,
>  Phil

Phillip,

Take a look at patch 115 of 118 in your series.  I did not review the
whole series, I just poked around briefly and noticed this one.

Greg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/