linux-kernel - Re: [PATCH 09/16] freezer: make freezing indicate freeze condition in effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110829073131.GD16431@mtj.dyndns.org>
Date:	Mon, 29 Aug 2011 09:31:31 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	rjw@...k.pl, menage@...gle.com, linux-kernel@...r.kernel.org,
	arnd@...db.de
Subject: Re: [PATCH 09/16] freezer: make freezing indicate freeze condition
 in effect

On Sun, Aug 28, 2011 at 07:56:01PM +0200, Oleg Nesterov wrote:
> > +	/* leave FROZEN */
> > +	spin_lock_irq(&freezer_lock);
> > +	current->flags &= ~PF_FROZEN;
> > +	spin_unlock_irq(&freezer_lock);
> 
> What if freezing() is true again when we are going to clear
> PF_FROZEN?
> 
> In this case the 2nd try_to_freeze_tasks() can see this task
> as already frozen and return success while it is going to run.

Indeed, if we need to do if (frezing) goto retry; there.  Will fix.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/