linux-kernel - RE: [PATCH 1/3] x86, intel: Output microcode revision v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <493994B35A117E4F832F97C4719C4C040133090FB8@orsmsx505.amr.corp.intel.com>
Date:	Mon, 29 Aug 2011 18:12:11 -0700
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	Andi Kleen <andi@...stfloor.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"x86@...nel.org" <x86@...nel.org>, Andi Kleen <ak@...ux.intel.com>,
	"Yu, Fenghua" <fenghua.yu@...el.com>
Subject: RE: [PATCH 1/3] x86, intel: Output microcode revision v4

>--- a/arch/x86/kernel/cpu/intel.c
>+++ b/arch/x86/kernel/cpu/intel.c
>@@ -364,6 +364,15 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
>
>       early_init_intel(c);
>
>+       if (c->x86 >= 6 && !cpu_has(c, X86_FEATURE_IA64)) {
>+               unsigned lower_word;
>+
>+               wrmsr(MSR_IA32_UCODE_REV, 0, 0);
>+               /* The CPUID 1 fills in the MSR as documented in the SDM */
>+               cpuid_eax(1);
>+               rdmsr(MSR_IA32_UCODE_REV, lower_word, c->microcode);
>+       }
>+

The patch initializes c->microcode AFTER it was used in early_init_intel(c) in your patch set [2/3].

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/