linux-kernel - Re: [PATCH] i2c: remove deprecated callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110901150105.31111b67@endymion.delvare>
Date:	Thu, 1 Sep 2011 15:01:05 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Randy Dunlap <rdunlap@...otime.net>,
	Ben Dooks <ben-linux@...ff.org>, linux-doc@...r.kernel.org,
	linux-i2c@...r.kernel.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH] i2c: remove deprecated callbacks

On Thu, 1 Sep 2011 17:12:00 +0800, Américo Wang wrote:
> On Thu, Sep 1, 2011 at 4:52 PM, Jean Delvare <khali@...ux-fr.org> wrote:
> > Furthermore, you didn't even check if the deprecated callbacks were
> > still in use. It turns out that there are 9 drivers still using one of
> > them (6 macintosh drivers and 3 sound drivers) so plain removing it
> > will cause build breakages. We obviously don't want to do that, so I am
> > not going to apply your patch (nor mine) for now.
> 
> Hmm, sorry that I didn't know this, maybe we can defer the removal
> of these callbacks?

We have to, obviously. And given that this is 50% of the patch, there's
little point in applying the rest now.

> > (...)
> > If you want to help, then instead of sending a patch which I already
> > have and virtually everybody could have written, please get the
> > remaining 3 drivers converted to the current i2c binding model:
> >  sound/ppc/keywest.c
> >  sound/aoa/codecs/onyx.c
> >  sound/aoa/codecs/tas.c
> 
> Sure, if I can... so how do we convert them? Any examples?

If it was trivial, someone would have done it already... I converted
most drivers a couple years ago, but the remaining ones only run on
systems I don't have and converting them properly would take intimate
knowledge of the systems in question and preferably actual hardware for
testing.

You can read the possible replacements for the current deprecated
implementations:
  Documentation/i2c/instantiating-devices

At the moment I am essentially waiting to see when Ben is headed, as
hopefully the sound drivers can follow the same path. If you want to
help Ben with code review or testing (if you can) this would be great.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/