linux-kernel - Re: [PATCH] i2c: remove deprecated callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVGO6Jfcdy4wWN7O-ZpTha2SbfK6xeaf8g9DRGuh=xcbg@mail.gmail.com>
Date:	Thu, 1 Sep 2011 17:12:00 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Randy Dunlap <rdunlap@...otime.net>,
	Ben Dooks <ben-linux@...ff.org>, linux-doc@...r.kernel.org,
	linux-i2c@...r.kernel.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH] i2c: remove deprecated callbacks

On Thu, Sep 1, 2011 at 4:52 PM, Jean Delvare <khali@...ux-fr.org> wrote:
> Hi Cong,
>
> On Thu,  1 Sep 2011 12:40:27 +0800, WANG Cong wrote:
>> i2c_driver.attach_adapter and i2c_driver.detach_adapter are deprecated
>> and scheduled to be removed in Sep 2011.
>>
>> Cc: Jean Delvare <khali@...ux-fr.org>
>> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
>
> I'm not sure what you are trying to achieve here.

I just want to make feature-removal-schedule.txt working. :)

>
> I am obviously aware of these functions being deprecated, I am the one
> who added the entry in feature-removal-schedule.txt. And as a matter of
> fact, I have a patch ready for months now.
>
> I could understand you sending a patch if the entry had expired long
> ago, but this isn't the case: it is marked for September 2011 and you
> send a patch on September 1st. Hardly a coincidence. While there
> certainly is a benefit in people reading feature-removal-schedule.txt
> and trying to clean it up by closing old (presumably forgotten)
> entries, this doesn't apply here.
>
> Furthermore, you didn't even check if the deprecated callbacks were
> still in use. It turns out that there are 9 drivers still using one of
> them (6 macintosh drivers and 3 sound drivers) so plain removing it
> will cause build breakages. We obviously don't want to do that, so I am
> not going to apply your patch (nor mine) for now.

Hmm, sorry that I didn't know this, maybe we can defer the removal
of these callbacks?

>
> I know that Benjamin Herrenschmidt is working on converting (some of)
> the macintosh drivers. I don't have any news for some time though. Ben,
> are you done with the conversion by now? It would be great to get it
> merged in kernel 3.2.
>
> Cong, do you have a specific interest in these callbacks being removed?
>
> If you want to help, then instead of sending a patch which I already
> have and virtually everybody could have written, please get the
> remaining 3 drivers converted to the current i2c binding model:
>  sound/ppc/keywest.c
>  sound/aoa/codecs/onyx.c
>  sound/aoa/codecs/tas.c

Sure, if I can... so how do we convert them? Any examples?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/