linux-kernel - RE: [PATCH 1/1] staging: hv: Add support for >2 TB LUN in storage driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A19259D4D4D02A429E578F34E2857F9D4D217013@TK5EX14MBXC203.redmond.corp.microsoft.com>
Date:	Tue, 6 Sep 2011 19:14:01 +0000
From:	Mike Sterling <Mike.Sterling@...rosoft.com>
To:	Greg KH <greg@...ah.com>
CC:	Haiyang Zhang <haiyangz@...rosoft.com>,
	Hank Janssen <hjanssen@...rosoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>
Subject: RE: [PATCH 1/1] staging: hv: Add support for >2 TB LUN in storage
 driver.

On Tuesday, September 06, 2011 12:06 PM, Greg KH wrote:
>On Thu, Sep 01, 2011 at 03:11:09PM -0700, Mike Sterling wrote:
>> If a LUN larger than 2 TB is attached to a Linux VM on Hyper-V, we 
>> currently report a maximum size of 2 TB. This patch resolves the issue in hv_storvsc.
>> Thanks to Robert Scheck <robert.scheck@...s.de> for reporting the issue.
>> 
>> Reported-by: Robert Scheck <robert.scheck@...s.de>
>> Signed-off-by: Mike Sterling <mike.sterling@...rosoft.com>
>> Signed-off-by: K.Y. Srinivasan <kys@...rosoft.com>
>> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
>> ---
>>  drivers/staging/hv/hyperv_storage.h |    1 +
>
>This file is no longer in the latest kernel tree (linux-next or staging-next).  What tree did you generate this patch against?  And >how come Haiyang and KY didn't catch such a basic mistake in their review...
>
>I'm guessing that this patch was not even tested :(
>
>Please fix this and resend.

Greg,

This patch was reviewed by both Ky and Haiyang. However, it looks like I built the patch against an older tree that didn't have Ky's changes. The "how" is still unclear, even after reviewing my steps with Ky. I've discussed this with Ky, I'm rebuilding the patch today, and will resubmit once we confirm.

-Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/